docs: Rewrite supported expressions page to show complete overview of what is and is not supported by Comet#4550
Merged
andygrove merged 27 commits intoJun 2, 2026
Conversation
…SQL functions section
…scope section, reclassify aes_* as codegen-dispatch candidates
…ep; record fallback reasons
…ence (mark newly-confirmed supported)
…-of-scope; mark literal-resolving funcs supported
…ns are classified
…ve list; drop fully out-of-scope csv/xml sections
andygrove
changed the title
comphead
reviewed
Jun 1, 2026
| narrow real-world analytics use and high implementation cost. These will fall back to Spark and | ||
| are not on the roadmap: | ||
|
|
||
| - **Probabilistic sketches and approximate top-k** (`kll_sketch_*`, `hll_*`, `theta_*`, `count_min_sketch`, `bitmap_*`, `approx_top_k*`): specialized data structures with exact-correctness traps. |
Contributor
There was a problem hiding this comment.
those are very popular in distinct aggregation which allows some approximation, would it be correct to outscope, or move to later phases in roadmap?
Member
Author
There was a problem hiding this comment.
do you think we can implement these natively with 100% compatibility? I haven't looked into this
comphead
reviewed
Jun 1, 2026
|
|
||
| --- | ||
|
|
||
| ## Out-of-scope function list |
comphead
reviewed
Jun 1, 2026
| - **User-defined functions:** Scala UDFs registered through the DataFrame or SQL API. | ||
| - **Structural expressions:** aliases, attribute references, literals, sort orders, and `CASE WHEN`. | ||
|
|
||
| This list is illustrative, not exhaustive: the per-function tables are not the complete set of expressions Comet can accelerate. |
Contributor
There was a problem hiding this comment.
from the text in this section it is not clear if such cases supported/planned or falls back
…ount_distinct and uuid; move approx_percentile to not-planned; remove redundant end list
Member
Author
|
Merged. Thanks @comphead. Let's keep iterating on this. Docs PRs are cheap now. Everyone should feel free to create PRs to make edits for these pages. I'm going to be updating this as other pending PRs are merged to mark more expressions as implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
See rendered version.
How are these changes tested?