Skip to content

fix #4296: Typescript target BaseListener/Visitor - #4994

Open
studio315b wants to merge 12 commits into
antlr:devfrom
studio315b:feature/4296-typescript-fixes
Open

studio315b wants to merge 12 commits into
antlr:devfrom
studio315b:feature/4296-typescript-fixes

Conversation

@studio315b

Copy link
Copy Markdown

The TS target now generates the same base Abstract & supporting Interface classes that the other Targets that support interfaces do.

This change was developed by @Nysosis but a pull request was never made. I've rebased to latest and fixed merge conflicts. Manual testing locally shows that this change works as intended, but I don't know if there is more work that needs to be done.

Nysosis and others added 4 commits November 1, 2026 19:42
The TS target now generates the same base Abstract & supporting Interface classes that the other Targets that support interfaces do.

Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
…he ParseTreeVisitor interface to IParseTreeVisitor

Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
…ions instead of assignments

Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
@studio315b
studio315b force-pushed the feature/4296-typescript-fixes branch from 6dee99c to 04551ac Compare November 2, 2026 03:43
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
@studio315b

Copy link
Copy Markdown
Author

Leaving a note for why the commits are weird:

Unit tests are failing for unrelated reasons locally on both archlinux and windows for me, so I have to test in commit 😭

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/tmp/TsNodeRunner-ForkJoinPool-1-worker-53-1793646479992/L.js' imported from /tmp/TsNodeRunner-ForkJoinPool-1-worker-53-1793646479992/Test.ts

Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
@studio315b
studio315b force-pushed the feature/4296-typescript-fixes branch from 8d215d2 to b29dcac Compare November 2, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants