Repository navigation
fix #4296: Typescript target BaseListener/Visitor - #4994
Open
studio315b wants to merge 12 commits into
Open
studio315b wants to merge 12 commits into
studio315b wants to merge 12 commits into
Conversation
The TS target now generates the same base Abstract & supporting Interface classes that the other Targets that support interfaces do. Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
…he ParseTreeVisitor interface to IParseTreeVisitor Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
…ions instead of assignments Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
studio315b
force-pushed
the
feature/4296-typescript-fixes
branch
from
November 2, 2026 03:43
6dee99c to
04551ac
Compare
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Author
|
Leaving a note for why the commits are weird: Unit tests are failing for unrelated reasons locally on both archlinux and windows for me, so I have to test in commit 😭 |
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
Signed-off-by: Ruu Nichols <rnichols@studio315b.com>
studio315b
force-pushed
the
feature/4296-typescript-fixes
branch
from
November 2, 2026 21:50
8d215d2 to
b29dcac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TS target now generates the same base Abstract & supporting Interface classes that the other Targets that support interfaces do.
This change was developed by @Nysosis but a pull request was never made. I've rebased to latest and fixed merge conflicts. Manual testing locally shows that this change works as intended, but I don't know if there is more work that needs to be done.