Repository navigation
Test pages CSS cache key inputs - #8315
Merged
gianfrancopiana merged 1 commit intoOct 10, 2026
Merged
Conversation
Member
Author
Contributor
|
gianfrancopiana
marked this pull request as ready for review
October 10, 2026 18:53
gianfrancopiana
deleted the
gianfranco/test-main-pages-cache-key-inputs
branch
October 10, 2026 18:53
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add regression checks that the pages CSS cache tag changes when its build script, CSS input, package lock, or rake task changes.
Why
PR #8312 added the pages CSS cache. Its tests covered restore and save behavior, but did not prove that representative build inputs invalidate the cache key.
Before/After
Before: cache-key input changes had no direct regression coverage.
After: the shell harness checks each representative input independently and confirms unrelated changes keep the key stable.
Test Results
bash .buildkite/scripts/main_asset_cache_compile_test.sh— 63 passed, 0 failedbin/test-confidence --strict— no tests selected because the diff only changes the shell harnessQA
No manual QA needed. This is test-only coverage for the existing cache key.
Implemented with Claude Sonnet 5.5.