Skip to content

Test pages CSS cache key inputs - #8315

Merged
gianfrancopiana merged 1 commit into
mainfrom
gianfranco/test-main-pages-cache-key-inputs
Oct 10, 2026
Merged

gianfrancopiana merged 1 commit into
mainfrom
gianfranco/test-main-pages-cache-key-inputs

Conversation

@gianfrancopiana

Copy link
Copy Markdown
Member

What

Add regression checks that the pages CSS cache tag changes when its build script, CSS input, package lock, or rake task changes.

Why

PR #8312 added the pages CSS cache. Its tests covered restore and save behavior, but did not prove that representative build inputs invalidate the cache key.

Before/After

Before: cache-key input changes had no direct regression coverage.

After: the shell harness checks each representative input independently and confirms unrelated changes keep the key stable.

Test Results

  • bash .buildkite/scripts/main_asset_cache_compile_test.sh — 63 passed, 0 failed
  • Mutation controls — removing each tested input from the key produced its intended failure
  • bin/test-confidence --strict — no tests selected because the diff only changes the shell harness
  • Private Claude Sonnet 5.5 high-effort review — clean

QA

No manual QA needed. This is test-only coverage for the existing cache key.


Implemented with Claude Sonnet 5.5.

@gianfrancopiana gianfrancopiana self-assigned this Oct 10, 2026
@gianfrancopiana

Copy link
Copy Markdown
Member Author

@greptileai

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This test-only change appears safe to merge.

Summary

Adds regression checks for the pages CSS cache key.

  • The cache test checks which pages CSS inputs change its tag.

Reviews (1) · Last reviewed commit: "Test pages CSS cache key inputs" · Reviewed by Greptile

@gianfrancopiana
gianfrancopiana marked this pull request as ready for review October 10, 2026 18:53
@gianfrancopiana
gianfrancopiana merged commit a1502d4 into main Oct 10, 2026
52 checks passed
@gianfrancopiana
gianfrancopiana deleted the gianfranco/test-main-pages-cache-key-inputs branch October 10, 2026 18:53

This branch was successfully deployed

1 active deployment
preview/gianfranco-test-main-page-06f22a — f77f966b Deployed Oct 10, 2026 by gumroad-buildkite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants