Fix CUDA long-context smoke test linking - #1030
Open
Matthley wants to merge 1 commit into
Open
Conversation
Link ds4_image.o so the test resolves ds4_deepseek4_attention_bounds and can run on CUDA hosts.
This was referenced Sep 12, 2026
|
Independent confirmation on a second DGX Spark (GB10 / sm_121, CUDA 13.0). Reproduced the failure first, on the current head of #952 ( With the one-line change applied, it links and the test passes: Worth noting for anyone else building on CUDA: |
|
merged with some conflicts resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ds4_image.ointotests/cuda_long_context_smokeds4_deepseek4_attention_boundsforcuda-regressionRequested by @GiorgioOppo in #952.
Test plan
make clean && make CUDA_ARCH=sm_121 cuda-regressionmake -j4 cuda-spark