Repository navigation
🐛 fix(mangowm): open the power menu again on mango 0.18 - #11
Merged
Merged
Conversation
With --no-span and -P, wlogout's layer-shell surface stayed invisible on every output. Without them the compositor puts it on the focused output, where the margins already centre it. The monitor size now comes from mmsg and jq instead of Python and GDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The power menu (Super+X and the Waybar power button) stopped opening.
Cause
On mango 0.18.5, wlogout's layer-shell surface stays invisible on every output when it gets
--no-span -P <monitor>, whatever the CSS. The CSS from before #10 reproduces it, so #10 did not cause it.Fix
power-menuno longer passes--no-spanor-P. The compositor puts the menu on the focused output, centred by the existing margins, and dims the other monitor.mmsg get all-monitorswithjq, a dependency of the layer, instead of Python with GDK. The menu still falls back to 1920x1080.Testing
layers/wm/mangowm/tests/waybar-smoke.shfails if wlogout gets--no-spanor-P. It also checks that it uses layer-shell and the margins of the active monitor.tests/smoke.shpasses.