feat(conformance): settle 0B Bucket C — capability conventions + WaitReady key set - #39
Merged
Merged
Conversation
…Ready key set Close out the last Phase 0B item (#27 Bucket C): the two capability-surface conventions and the WaitReady diagnostics key set, documented in the executable profile and asserted in the (waivable) executable-profile suite — conventions, not core ADPP. - checks.py: assert_signal_ids_snake_case (signal_id ^[a-z][a-z0-9_]*$) and assert_function_ids_per_type_from_one (per-device function_ids are {1..N}). - test_executable_profile.py: test_signal_ids_snake_case + test_function_ids_per_type_from_one (executable_profile-marked -> waivable). - test_selftest.py: hermetic validator self-tests (good + bad cases). - anolis-executable-profile-v1.md: settle the WaitReady key set (init_time_ms required; ready/device_count/provider_impl recommended) and add a Capability conventions section. - ADPP-CONFORMANCE.md: fold the two checks into the executable-profile summary; retire the 'not yet covered' note. Validated against the released binaries: bread passes both, ezo fails both (ph.value; function_ids 1001-1003), sim passes (its mock config exposes only the compliant tempctl). 34 hermetic self-tests pass. Closes #27
|
The latest Buf updates on your PR. Results from workflow CI / lint (pull_request).
|
CameronBrooks11
enabled auto-merge (squash)
June 22, 2026 15:06
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the final Phase 0B item (#27 Bucket C), completing Wave 0 of the conformance epic (#25).
What
Two capability-surface conventions + the WaitReady diagnostics key set — documented in the executable profile and asserted in the waivable executable-profile suite (conventions, not core ADPP), per the locked decisions (audit §6.7/§6.8/§6.1).
checks.py—assert_signal_ids_snake_case(signal_idmatches^[a-z][a-z0-9_]*$) andassert_function_ids_per_type_from_one(each device'sfunction_ids are the contiguous set{1..N}).test_executable_profile.py—test_signal_ids_snake_case+test_function_ids_per_type_from_one,executable_profile-marked so a non-compliant provider can waive them with an issue link.test_selftest.py— hermetic validator self-tests (good + bad cases).anolis-executable-profile-v1.md— settle the WaitReady key set (init_time_msrequired;ready/device_count/provider_implrecommended) and add a Capability conventions §4.ADPP-CONFORMANCE.md— fold both checks into the executable-profile summary; retire the "not yet covered" note.Non-breaking
The new assertions ship in a future release; all three providers pin v1.4.0, so their lanes are unaffected now. Validated against the released binaries with the branch harness:
tempctl)ph.value1001–100334 hermetic self-tests pass; full bread run green (35 passed, 1 xfailed = its init_time_ms waiver).
Follow-ups (Wave 3, separate issues)
signal_ids → snake_case; globalfunction_ids → per-type from 1 (its future waiver reason / fix).motorctlfunction_id=10→ 1 (not currently exposed by the mock config).