chore: retire the workbench system.json shim - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
projects/bioreactor-v1/workbench/system.json, dead sinceanolis-workbench#255.Why it is dead
Before #255 the workbench kept its own shadow document (
system.json) and rendered the canonical artifacts from it. Since the flip, a workbench project IS the canonical machine-profile directory —machine-profile.yaml+config/+behaviors/— and deploying is a byte-copy. The workbench imports this project verbatim (#226) and writes only its ownworkbench.jsonsidecar, inside its own state directory, never here.Nothing reads this file: not
install.sh, not the workbench, not CI.Keeping it is worse than clutter — it is a second description of the machine that no longer has to agree with
machine-profile.yaml, and nothing would notice if it drifted. That is the same fork-goes-stale failure that removed the workbench'sbioreactor-manualtemplate in #280, where the template had silently lostcommand_watchdog_ms: 5000from all three bread devices.Docs
Two places described it as part of the project layout and are updated in the same commit, so the repo does not document a file that no longer exists:
GOVERNANCE.md— dropped from the per-project contents listREADME.md— the conventions line now says a project directory is the artifact setinstall.shconsumes and the workbench imports verbatimTracked workbench-side as
anolis-workbench#288(deleting the code that used to read it).