Repository navigation
Clean up the logic to disable of android device tests - #178
Conversation
liutikas
commented
Nov 13, 2025
- selector().all() is the default value, drop it
- Remove androidTestImplementation from projects that disable tests
- selector().all() is the default value, drop it - Remove androidTestImplementation from projects that disable tests
Summary of ChangesHello @liutikas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the configuration for disabling Android device tests across various modules. It streamlines the build scripts by removing default and unused declarations, specifically by simplifying the variant selection logic and eliminating test dependencies from modules that do not run Android tests. This change improves build clarity and reduces potential overhead. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively cleans up the Gradle build scripts by removing redundant code. The simplification of beforeVariants calls by removing the default selector().all() and the removal of unused androidTestImplementation dependencies in modules with disabled Android tests are both excellent changes that improve code clarity and maintainability. The changes are correct and well-implemented across all affected modules.