Repository navigation
fix: document wc, expose help, and correct newline counting - #3277
Open
hengyunabc wants to merge 2 commits into
Open
hengyunabc wants to merge 2 commits into
hengyunabc wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wcpipe handler lacks usable command help and dedicated documentation. Its current counter also drops blank lines and can count the same line twice when output arrives in separate writes.This change registers
wcwith the command framework sohelp wc,wc -h, andwc --helpwork, and shares the-l/--linesoption definition with the pipe handler. It adds Chinese and English documentation, command-list links, sidebar entries, and help-list examples.The counter now counts
\ncharacters using an atomic long. Blank lines count, CRLF counts once, and an unterminated final line does not add a count. Results no longer depend on write boundaries. The help/documentation work and counting fix are kept in separate commits.Validation:
./mvnw -B -ntp -pl core -am testpassed, including 322 core tests (0 failures/errors; 7 existing skips) and dependency-module tests.npm --prefix site run docs:buildpassed (158 pages); verified rendered examples, counting rules, and Chinese/English command-list and sidebar links.git diff origin/master...HEAD --checkpassed.Full distribution packaging is not verified: a local package attempt passed the tests but stopped because the Web UI build output at
web-ui/arthasWebConsole/dist/uiwas absent.Related to #2322.