Repository navigation
Fix MCP SSE response connection reuse race - #3268
Open
hengyunabc wants to merge 1 commit into
Open
hengyunabc wants to merge 1 commit into
hengyunabc wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP POST SSE responses advertise
Connection: keep-alive, but the transport closes the connection after sending each response. HTTP clients can cache and reuse the closing connection, causing intermittentUnexpected end of file from serverfailures on consecutivetools/callrequests.Advertise
Connection: closefor these responses to match the existing transport lifecycle. Add a regression assertion to the MCP integration test so this mismatch fails deterministically instead of depending on connection-close timing.Validation:
expected: close, but was: keep-alive)../mvnw -B -ntp -pl packaging -am package -DskipTests— passed../mvnw -B -ntp -pl arthas-mcp-server -am test— 13 tests passed../mvnw -B -ntp -pl arthas-mcp-integration-test verify— 38 integration tests passed.