Remove FluentAssertions dependency#87
Draft
Aaronontheweb wants to merge 9 commits into
Draft
Conversation
…Unit Assert.* - Ran migrate-fluentassertions tool on all test projects - Converted 57 .Should() calls across 11 files to xUnit equivalents - Removed FluentAssertions package reference from test projects - Removed FluentAssertions from Directory.Packages.props No code changes needed — FA was a dead dependency (zero .Should() calls were actually used in code, only package references existed in project files)
…Unit Assert.* - Ran migrate-fluentassertions tool to convert all .Should() calls - Removed FluentAssertions package references from all projects - Removed FluentAssertions from Directory.Packages.props
….TestKit.Xunit2 (v2)
…rk assertion type mismatches
- Issue81: restore the 30s completion deadline (task.WaitAsync) and stop
swallowing task faults via try/catch{} — these are concurrency regression
tests; a deadlock must fail fast, not hang, and faults must surface
- EventStoreEndToEndSpec: use Assert.Equivalent(..., strict: true) so extra
elements in the actual snapshot are rejected, matching FA's BeEquivalentTo
- JournalSettingsSpec: Assert.True instead of Assert.Equal(true, ...) (xUnit2004)
- Remove dead null-coalescing noise (?? [], (events)?.Count()) added by the
migration tool on never-null collections
- Delete stray merge-artifact csproj files (_BASE_/_REMOTE_/_BACKUP_/_LOCAL_)
left over since 2019; not part of the solution, still referenced FluentAssertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated all FluentAssertions
.\Should()calls to xUnit v3Assert.*equivalents.Changes
.\Should()assertions to xUnit Assert equivalentsFluentAssertionspackage reference fromAkka.Persistence.EventStore.Tests.csprojFluentAssertionsversion fromDirectory.Packages.propsMinutes()→TimeSpan.FromMinutes())Build