Repository navigation
Correct the v0.4.0 migration notes - #139
Merged
Merged
Conversation
The migration paragraph told adopters to regenerate the config with init, which writes a blank starter and drops the gate, engine, and attribution settings; the right first step is renaming the old config file so init keeps its values. It also never said to delete the old caller workflow, which otherwise keeps firing on the same events, and it offered labelPrefix: sc as an escape hatch that the generated caller's literal ax:go trigger cannot honor. State each of those plainly, warn that the optional SIMPLYCUBED_DRY_RUN/SANDBOX flags are ignored rather than failing, note that in-flight sc:* issues must be finished before upgrading, and fix an article in a loop.go comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adversarial review of the rebrand (#137) confirmed three defects in the v0.4.0 CHANGELOG section, all in what it tells a migrating adopter to do:
.github/workflows/simplycubed.ymlkeeps firing on the same mention and label events after migration: duplicate runs with the old variables still set, a permanently failing run next to every real one once they are renamed.initon a repo with no.github/aixgo.ymlwrites a blank starter, droppinggate:,engine:, andattribution:. The right first step is renaming the old config file, whichinitthen preserves.labelPrefix: scescape hatch cannot work through Actions. The generated caller triggers on the literalax:go, so a repo configured back toscappliessc:goand silently starts nothing.The section now gives the migration as five ordered steps, warns that the optional
SIMPLYCUBED_DRY_RUN/SIMPLYCUBED_SANDBOXexports are silently ignored rather than failing (the required-value "fails loudly" claim was only true for required values), notes that in-flightsc:*issues must be finished before upgrading, and documents that the ledger starts fresh onaixgo/ledgerwith prior history remaining on the old branch.Also fixes "a Aixgo Code marker" in a loop.go comment.
make checkgreen;verify-release.sh v0.4.0still consistent.