Repository navigation
Closes #95: engine: claude is selectable but cannot actually be used - #102
Conversation
Co-Authored-By: SimplyCubed Code <noreply@simplycubed.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
charlesgreen
left a comment
There was a problem hiding this comment.
Verified against the acceptance criterion in #95 rather than the diff alone. On this branch, with a config saying engine: claude and no Azure variables set:
$ simplycubed preflight --repo-dir .
preflight ok: config and engine settings are present
and with the engine left at the default, the requirement is still enforced:
error: AZURE_OPENAI_ENDPOINT is not set. ...
codex.WriteConfig is gated on the same condition, so a Claude run no longer writes a provider config it never reads. The docs are scoped correctly, including the caveat that the hosted path remains Codex-only.
Steps 2 and 4 of #95 are untouched, which is correct: they need a change under .github/workflows/, and the App deliberately holds no workflows permission. Filing that separately.
The first release whose GitHub Actions runtime can do work. v0.1.7 could not be loaded at all, and v0.1.8 loaded but its engine sandbox could not start on an Ubuntu 24.04 runner, so every Actions run under it escalated without proposing anything. STATUS now records the dogfooding fact that matters: the loop, running in this repository's own Actions, produced PR #102 against issue #95.
Automated change from an issue. A human reviews and merges; this loop does not.
Walkthrough
This change makes
engine: claudeusable through the local CLI path that was already wired up underneath.preflightandpreparenow load the repo config before validating engine settings, skip Azure credential checks when the selected engine is Claude, and avoid rendering Codex provider config for a Claude run. That removes the false Azure dependency from local Claude executions while preserving the existing Azure-backed Codex path.The documentation is updated to match the new boundary precisely. README, setup docs, and status notes now say that Claude works for local CLI runs authenticated through the
claudeCLI, but the reusable GitHub Actions workflow is still Codex-on-Azure only because it installs only the Codex CLI and still requires Azure inputs and secrets.Changes
engine: clauderuns.Sequence diagram
Generated description — verify against the diff.
🤖 Generated with SimplyCubed Code