fix(harness): drain local shell output while process runs - #2936
Open
CryoThrust wants to merge 2 commits into
Open
fix(harness): drain local shell output while process runs#2936CryoThrust wants to merge 2 commits into
CryoThrust wants to merge 2 commits into
Conversation
Signed-off-by: Yohanes <CryoThrust@users.noreply.github.com>
|
|
Signed-off-by: Yohanes <CryoThrust@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2838.
LocalFilesystemWithShell.executewaited for the process before consuming stdout and stderr. Commands producing more than the OS pipe buffer could deadlock and be reported as timeouts.This change starts daemon stream readers immediately after process startup, waits for the process with the existing timeout, and then collects both outputs. It preserves output truncation and timeout response behavior and adds a regression test covering approximately 108 KB of stdout.
Signed-off-by: Yohanes CryoThrust@users.noreply.github.com