Skip to content

fix(dashscope): broaden kimi-k multimodal detection to cover all vari… #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charliejinc wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −3
Open

fix(dashscope): broaden kimi-k multimodal detection to cover all vari… #2928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...dashscope/src/main/java/io/agentscope/extensions/model/dashscope/DashScopeHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,9 @@ public static boolean isMultimodalModel(String modelName) {
String lowerModelName = modelName.toLowerCase();
// Reverse exclusions: text-only models whose prefix would otherwise match.
if (lowerModelName.equals("qwen3.6-max-preview")
|| lowerModelName.startsWith("qwen3.7-max")) {
|| lowerModelName.startsWith("qwen3.7-max")
|| lowerModelName.contains("kimi-k2-thinking")
|| lowerModelName.contains("moonshot-kimi-k2-instruct")) {
return false;
}
return lowerModelName.startsWith("qvq")
Expand All @@ -403,8 +405,7 @@ public static boolean isMultimodalModel(String modelName) {
|| lowerModelName.startsWith("qwen3.6")
|| lowerModelName.startsWith("qwen3.7")
|| lowerModelName.startsWith("qwen3.8-max")
|| lowerModelName.contains("kimi-k2.5")
|| lowerModelName.contains("kimi-k2.6");
|| lowerModelName.contains("kimi-k");
}

/**
Expand Down
14 changes: 14 additions & 0 deletions ...scope/src/test/java/io/agentscope/extensions/model/dashscope/DashScopeHttpClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,20 @@ void testIsMultimodalModelPatterns() {
assertFalse(DashScopeHttpClient.isMultimodalModel(""));
}

@Test
void testIsMultimodalModelKimiFamily() {
// kimi-k variants with vision/multimodal support
assertTrue(DashScopeHttpClient.isMultimodalModel("kimi-k2.5"));
assertTrue(DashScopeHttpClient.isMultimodalModel("kimi-k2.6"));
assertTrue(DashScopeHttpClient.isMultimodalModel("kimi-k2.7-code"));
assertTrue(DashScopeHttpClient.isMultimodalModel("kimi-k3"));
assertTrue(DashScopeHttpClient.isMultimodalModel("kimi/kimi-k2.5"));
assertTrue(DashScopeHttpClient.isMultimodalModel("Moonshot-Kimi-K2.5"));
// Text-only kimi models
assertFalse(DashScopeHttpClient.isMultimodalModel("kimi-k2-thinking"));
assertFalse(DashScopeHttpClient.isMultimodalModel("Moonshot-Kimi-K2-Instruct"));
}

@Test
void testRequestEndpointTypePassedToEndpointSelection() throws Exception {
// Verify that endpointType in DashScopeRequest is used for endpoint routing
Expand Down
Loading