fix(harness): preserve Docker exec commands on Windows - #2925
Open
guslegend0510 wants to merge 6 commits into
Open
fix(harness): preserve Docker exec commands on Windows#2925guslegend0510 wants to merge 6 commits into
guslegend0510 wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.3-SNAPSHOT
Description
Fixes #2924
DockerSandbox.doExec()previously passed the complete shell command as the finaldocker.exeargument (sh -c <command>). On Windows, nested double quotes can be altered while the Win32 command line is serialized and parsed, breaking filesystem commands such aswrite_fileandedit_file.This PR:
docker exec -i ... sh -sand streams the command through UTF-8 stdin instead of placing it in argv;Testing
mvn -pl agentscope-harness -am -Dtest=DockerSandboxExecTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl agentscope-harness -am testmvn spotless:checkgit diff --checkChecklist
mvn spotless:applymvn test)