Conversation
Pi's assistant `message_start` snapshot can already contain a block's first delta: pi-ai documents `partial` as a shared live response-so-far helper, not an event-time snapshot, so a snapshot read at `*_start` may carry the chunk that the following `*_delta` delivers again. The reducer kept that text when `text_start`/`thinking_start` arrived and then appended the delta a second time, rendering the first word twice until the authoritative `*_end` replaced the whole block. Streamed tool input had the same problem. Reset text, thinking, and tool-call blocks on their `*_start` event instead, matching pi-ai's documented semantics (empty at start, grown only by deltas, `*_end` authoritative) and pi's own AssistantMessageEventProxy. Adds regression coverage for the leaked-first-chunk sequence in lib/streaming-message.test.mjs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi's assistant
message_startsnapshot can already contain a block's first delta: pi-ai documentspartialas a shared live response-so-far helper, not an event-time snapshot, so a snapshot read at*_startmay carry the chunk that the following*_deltadelivers again.The reducer kept that text when
text_start/thinking_startarrived and then appended the delta a second time, rendering the first word twice until the authoritative*_endreplaced the whole block. Streamed tool input had the same problem.Reset text, thinking, and tool-call blocks on their
*_startevent instead, matching pi-ai's documented semantics (empty at start, grown only by deltas,*_endauthoritative) and pi's own AssistantMessageEventProxy.Adds regression coverage for the leaked-first-chunk sequence in lib/streaming-message.test.mjs.
Before fix:
After fix:
