Repository navigation
fix(observability): reserve a loopback OTLP relay address - #8
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
Signed-off-by: Alex Fournier <afournier@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use an OpenShell-reserved loopback address for sandbox OTLP export so current NeMo Relay can send traces, logs, and metrics through the mediated telemetry path without a workload-side bridge.
This is the third signal-compatibility layer in the fork-only draft stack. OpenShell still intercepts the connection before the workload network stack can deliver it locally.
Related Issue
Extends NVIDIA#2641 and NVIDIA#3196. This draft does not close either issue.
Changes
192.0.0.8:4318to127.0.0.8:4318Testing
cargo test -q -p openshell-core relay_address_is_a_reserved_loopback_labelcargo test -q -p openshell-server otel_relaycargo test -q -p openshell-supervisor-process otlpmise run pre-commitopenshell.sandbox.idandopenshell.telemetry.sourcevalues were replaced on traces, logs, and metrics127.0.0.8:4318accepted zero connections while Relay telemetry still reached the collectorChecklist
Stack
Draft stacked on #7 (
codex/3196-stack-otlp-metrics). Review this PR as the reserved-loopback-only delta from that branch.