You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(prompt-field): show collapsed in the api table - #6847
Removes the @internal tag from the collapsed property on swc-prompt-field, so the property shows in the Storybook API table. The Playground render now passes collapsed to the element, so the new control works.
Motivation and context
collapsed is a public, reflected property that consumers can use, but @internal hid it from the API table.
Related issue(s)
fixes [Issue Number]
Screenshots (if appropriate)
Author's checklist
I have read the CONTRIBUTING and PULL_REQUESTS documents.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
I have added automated tests to cover my changes.
I have included a well-written changeset if my change needs to be published.
I have included updated documentation if my change required it.
Validation: no lint, build, or tests were run locally (dependencies are not installed in this worktree). CI will validate.
Reviewer's checklist
Includes a Github Issue with appropriate flag or Jira ticket number without a link
Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
Automated tests cover all use cases and follow best practices for writing
Validated on all supported browsers
All VRTs are approved before the author can update Golden Hash
Manual review test cases
collapsed shows in the API table
Go to the Storybook docs page for AI Toolkit/Prompt field
Find the API table
Expect a collapsed row with a boolean control
The Playground control works
Go to the Prompt field Playground story
Turn on the collapsed control
Expect the single-line layout with the send button inline
Device review
Did it pass in Desktop?
Did it pass in (emulated) Mobile?
Did it pass in (emulated) iPad?
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Go to the Prompt field Playground story and turn on collapsed
Press Tab through the component
Expect focus to reach the textarea and send button only; hidden leading actions are inert
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.
Go to the Prompt field Playground story and turn on collapsed
Navigate the component with a screen reader
Expect no change from current behavior; this PR only changes docs visibility
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
@internaltag from thecollapsedproperty onswc-prompt-field, so the property shows in the Storybook API table. The Playground render now passescollapsedto the element, so the new control works.Motivation and context
collapsedis a public, reflected property that consumers can use, but@internalhid it from the API table.Related issue(s)
Screenshots (if appropriate)
Author's checklist
Validation: no lint, build, or tests were run locally (dependencies are not installed in this worktree). CI will validate.
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
collapsedshows in the API tablecollapsedrow with a boolean controlThe Playground control works
collapsedcontrolDevice review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
collapsedScreen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.
collapsed