Skip to content

fix(styles): background-color of body is static to match bg images - #167

Merged
marissahuysentruyt merged 2 commits into
mainfrom
safari-bg
Oct 2, 2026
Merged

marissahuysentruyt merged 2 commits into
mainfrom
safari-bg

Conversation

@marissahuysentruyt

@marissahuysentruyt marissahuysentruyt commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Possible Safari bug with the picture/image BG after an image update. We specifically use loading="eager" and sizes="auto" on our light-mode image element, which might be clashing with Safari's support for size="auto", where they are specifically looking for lazy loaded image elements. 🤷‍♀️

https://webkit.org/blog/17967/news-from-wwdc26-webkit-in-safari-27-beta/

Version 27.0.1 (the bg image is sort of centered, but if you inspect the element, it still spans the whole screen.
Screenshot 2026-10-02 at 5 15 16 PM

This might be a temp fix. This PR is merging early just so the site isn't broken-looking on new versions of Safari all weekend. This doesn't change doesn't produce any any visible side effect on Chrome or Firefox.

Screenshots (if applicable)

Type of change

  • Bug fix
  • New feature / block
  • Refactor
  • Docs / content
  • Chore (deps, config, tooling)

Related issue(s)

  • fixes [Issue Number]

Validation steps

  • This PR has visual elements, so it was reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).
  • This PR affects existing pages, so automated E2E tests were run (see below).
  • This PR has new code, so new tests were added or updated, and they pass.
  • This PR has copy changes, so copy was proofread and approved.
  • The content of this PR requires documentation, so a detailed description of the component's purpose, requirements, quirks, and instructions for use by designers and developers was added, along with accessibility information if pertinent.

To Validate

URL for testing:
https://safari-bg--spectrum-hub--adobe.aem.live/

  • Make sure all PR Checks have passed
  • Pull down the branch locally or visit the branch preview
  • Run npm test and confirm all tests pass
  • Run npm run lint and confirm no linting errors
  • Verified in browser with aem up

Accessibility testing checklist

  • Keyboard
  1. Go here
  2. Do this action
  3. Expect this result
  • Screen reader
  1. Go here
  2. Do this action
  3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync

aem-code-sync Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@marissahuysentruyt
marissahuysentruyt marked this pull request as ready for review October 2, 2026 21:43
@aem-code-sync

aem-code-sync Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@marissahuysentruyt

Copy link
Copy Markdown
Collaborator Author

merging with known contrast issues for the se-textarea (unused in this repo) and se-input (it's the contrast between the default gray-300 border of the textfield and the f7f7f7 bg color)

@marissahuysentruyt
marissahuysentruyt merged commit a4710db into main Oct 2, 2026
7 of 9 checks passed
@marissahuysentruyt
marissahuysentruyt deleted the safari-bg branch October 2, 2026 22:00

This branch was successfully deployed

1 active deployment
safari-bg — 51844ac2 Deployed Oct 2, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant