fix(styles): background-color of body is static to match bg images - #167
Merged
Merged
Conversation
marissahuysentruyt
marked this pull request as ready for review
October 2, 2026 21:43
Collaborator
Author
|
merging with known contrast issues for the se-textarea (unused in this repo) and se-input (it's the contrast between the default gray-300 border of the textfield and the f7f7f7 bg color) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possible Safari bug with the picture/image BG after an image update. We specifically use
loading="eager"andsizes="auto"on our light-mode image element, which might be clashing with Safari's support forsize="auto", where they are specifically looking for lazy loaded image elements. 🤷♀️https://webkit.org/blog/17967/news-from-wwdc26-webkit-in-safari-27-beta/
Version 27.0.1 (the bg image is sort of centered, but if you inspect the element, it still spans the whole screen.

This might be a temp fix. This PR is merging early just so the site isn't broken-looking on new versions of Safari all weekend. This doesn't change doesn't produce any any visible side effect on Chrome or Firefox.
Screenshots (if applicable)
Type of change
Related issue(s)
Validation steps
To Validate
URL for testing:
https://safari-bg--spectrum-hub--adobe.aem.live/
npm testand confirm all tests passnpm run lintand confirm no linting errorsaem upAccessibility testing checklist
Device review
Checklist: