Repository navigation
Fix environment-controlled board detection - #420
Open
ladyada-eagleclaw wants to merge 6 commits into
Open
ladyada-eagleclaw wants to merge 6 commits into
ladyada-eagleclaw wants to merge 6 commits into
Conversation
Co-authored-by: Limor Fried <ladyada@users.noreply.github.com>
Co-authored-by: Limor Fried <ladyada@users.noreply.github.com>
Base MCP2222 support on the dedicated board-helper fix and keep its regression tests in that change. Co-authored-by: Limor Fried <ladyada@users.noreply.github.com>
Add opt-in MCP2222 USB bridge detection
Apply the environment-board helper correction to MCP2222 as well and include it in regression coverage. Co-authored-by: Limor Fried <ladyada@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detector().board.os_environ_boardincorrectly returnsFalsefor supported USB bridges. The property accessesself.boardeven thoughselfis already aBoard; the resulting attribute error is masked by the dynamic board-name lookup.Use
self.<board ID>throughout the existing generator, including the MCP2222 entry now onmain, and correctITSYBITY_U2IFtoITSYBITSY_U2IF. The diff is limited to this helper correction and its regression tests.Validation: all 26 unit tests and affected pre-commit hooks pass. Regression coverage checks MCP2221, MCP2222, FT232H, and ItsyBitsy U2IF, plus an unrelated board that must remain false. Local checks use Python 3.11 and a temporary Windows lint exception for existing Unix-only
os.unamereferences; repository hook configuration is unchanged.