IDE-5067: CLI push db command failing on IDE#1999
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses database push/pull failures in Code Studio/IDE (MEO/codebase-UUID context) by improving environment/database handling and adding an execution flag to skip Drupal cache clearing when needed.
Changes:
- Add MEO-aware environment normalization in telemetry.
- Make
push:dbmore resilient to MEO database responses (null DB URL) and missing environment SSH URL (via fallback). - Add
pull:db --no-cache-clearto skipdrush cache:rebuildwhile still allowing other post-import steps.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Helpers/TelemetryHelper.php |
Adds MEO normalization branch for AH environment telemetry. |
src/Command/Push/PushDatabaseCommand.php |
Adds SSH URL fallback logic and supports DB name derivation when DatabaseResponse::url is null (MEO). |
src/Command/Pull/PullDatabaseCommand.php |
Introduces --no-cache-clear option and gates cache rebuild accordingly. |
src/Command/CommandBase.php |
Populates siteId for codebase/MEO context to enable SiteInstance DB API usage. |
tests/phpunit/src/Misc/TelemetryHelperTest.php |
Adds test coverage for MEO telemetry normalization. |
tests/phpunit/src/Commands/Push/PushDatabaseCommandTest.php |
Adds test coverage for pushing a DB when DatabaseResponse::url is null (MEO-style response). |
tests/phpunit/src/Commands/Pull/PullDatabaseCommandTest.php |
Adds test coverage for --no-cache-clear behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This will be blocked on https://github.com/acquia/drupal-environment-detector/pull/111/changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
============================================
- Coverage 92.42% 92.37% -0.06%
- Complexity 1957 1964 +7
============================================
Files 123 123
Lines 7091 7109 +18
============================================
+ Hits 6554 6567 +13
- Misses 537 542 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1999/acli.phar |
No description provided.