Skip to content

IDE-5067: CLI push db command failing on IDE#1999

Open
deepakmishra2 wants to merge 6 commits into
mainfrom
IDE-5067
Open

IDE-5067: CLI push db command failing on IDE#1999
deepakmishra2 wants to merge 6 commits into
mainfrom
IDE-5067

Conversation

@deepakmishra2
Copy link
Copy Markdown
Contributor

@deepakmishra2 deepakmishra2 commented May 26, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 26, 2026 12:23
@deepakmishra2 deepakmishra2 added the bug Something isn't working label May 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses database push/pull failures in Code Studio/IDE (MEO/codebase-UUID context) by improving environment/database handling and adding an execution flag to skip Drupal cache clearing when needed.

Changes:

  • Add MEO-aware environment normalization in telemetry.
  • Make push:db more resilient to MEO database responses (null DB URL) and missing environment SSH URL (via fallback).
  • Add pull:db --no-cache-clear to skip drush cache:rebuild while still allowing other post-import steps.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Helpers/TelemetryHelper.php Adds MEO normalization branch for AH environment telemetry.
src/Command/Push/PushDatabaseCommand.php Adds SSH URL fallback logic and supports DB name derivation when DatabaseResponse::url is null (MEO).
src/Command/Pull/PullDatabaseCommand.php Introduces --no-cache-clear option and gates cache rebuild accordingly.
src/Command/CommandBase.php Populates siteId for codebase/MEO context to enable SiteInstance DB API usage.
tests/phpunit/src/Misc/TelemetryHelperTest.php Adds test coverage for MEO telemetry normalization.
tests/phpunit/src/Commands/Push/PushDatabaseCommandTest.php Adds test coverage for pushing a DB when DatabaseResponse::url is null (MEO-style response).
tests/phpunit/src/Commands/Pull/PullDatabaseCommandTest.php Adds test coverage for --no-cache-clear behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/phpunit/src/Misc/TelemetryHelperTest.php Outdated
Comment thread src/Command/CommandBase.php
Comment thread src/Command/Push/PushDatabaseCommand.php
@deepakmishra2 deepakmishra2 changed the title IDE-5067: CLI push and pull db command failing on code studio and IDE. [Do not merge] IDE-5067: CLI push and pull db command failing on code studio and IDE. May 27, 2026
@deepakmishra2
Copy link
Copy Markdown
Contributor Author

Copilot AI changed the title [Do not merge] IDE-5067: CLI push and pull db command failing on code studio and IDE. Fix telemetry MEO environment detection in CI May 27, 2026
@deepakmishra2 deepakmishra2 changed the title Fix telemetry MEO environment detection in CI [Do not merge] IDE-5067: CLI push and pull db command failing on code studio and IDE May 27, 2026
@deepakmishra2 deepakmishra2 changed the title [Do not merge] IDE-5067: CLI push and pull db command failing on code studio and IDE IDE-5067: CLI push and pull db command failing on code studio and IDE May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (60bb561) to head (b4f362a).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1999      +/-   ##
============================================
- Coverage     92.42%   92.37%   -0.06%     
- Complexity     1957     1964       +7     
============================================
  Files           123      123              
  Lines          7091     7109      +18     
============================================
+ Hits           6554     6567      +13     
- Misses          537      542       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1999/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1999/acli.phar
chmod +x acli.phar

@deepakmishra2 deepakmishra2 changed the title IDE-5067: CLI push and pull db command failing on code studio and IDE IDE-5067: CLI push db command failing on code studio and IDE May 27, 2026
@deepakmishra2 deepakmishra2 changed the title IDE-5067: CLI push db command failing on code studio and IDE IDE-5067: CLI push db command failing on IDE May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants