feat: add const-generic Gram matrix construction - #236
Conversation
- Add allocation-free, const-evaluable `gram_matrix` with independent vector count and dimension - Preserve bitwise symmetry and typed dot-product overflow diagnostics - Document geometric uses, conditioning, and floating-point limitations - Add benchmarks for square and rectangular vector collections - Simplify exact rational scaling using canonical positive denominators - Deduplicate factorization property-test fixtures and assertions
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (9)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe pull request adds a fixed-size ChangesGram matrix API
Rational denominator handling
Factorization test helpers
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The Gram matrix API, rational arithmetic cleanup, tests, benchmarks, and documentation do not present an identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 97.93% 97.99% +0.06%
==========================================
Files 12 13 +1
Lines 6574 6579 +5
==========================================
+ Hits 6438 6447 +9
+ Misses 136 132 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
gram_matrixwith independent vector count and dimensionCloses #219
Summary by CodeRabbit
New Features
gram_matrixfor allocation-free construction of symmetric Gram matrices from fixed-size vectors.Documentation
Tests
Refactor