feat(vector): add certified dot and affine error bounds - #232
Conversation
- Add proof-bearing scalar certificates for dot products and unrounded axis · (left - right) reductions. - Expose outward bounds for sign and threshold filtering, with inconclusive results when proof conditions fail. - Document and benchmark the deterministic FMA error model. Closes #220
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughChangesCertified linear-form evaluation
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This change adds certified dot-product and affine-reduction bounds with defined inconclusive and typed-error behavior. No current merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant Caller
participant Vector
participant FMA_Reduction
participant ScalarWithErrorBound
Caller->>Vector: request certified dot or dot difference
Vector->>FMA_Reduction: evaluate left-to-right FMA tree
FMA_Reduction->>ScalarWithErrorBound: construct estimate and bounds
ScalarWithErrorBound-->>Caller: return certificate or inconclusive result
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 97.87% 97.87% -0.01%
==========================================
Files 10 10
Lines 6069 6440 +371
==========================================
+ Hits 5940 6303 +363
- Misses 129 137 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
- Rename numerical-bound locals so CodeQL does not mistake them for sensitive certificate data. - Document finite bound invariants, the affine error formula, and typed failure contexts. - Make proof-range and second-FMA overflow expectations explicit.
Closes #220
Summary by CodeRabbit
New Features
ScalarWithErrorBoundthrough the main library interface and prelude.Documentation
Benchmarks