Skip to content

[data_release] Fixed delete files issue if language selected is not English - #10994

Open
fias06 wants to merge 6 commits into
aces:29.0-releasefrom
fias06:2026_07_21_fixing_delete_file_issue_when_not_English
Open

[data_release] Fixed delete files issue if language selected is not English#10994
fias06 wants to merge 6 commits into
aces:29.0-releasefrom
fias06:2026_07_21_fixing_delete_file_issue_when_not_English

Conversation

@fias06

@fias06 fias06 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

Now the files should be able to be deleted when the language is not set to English

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Go to data_release module
  2. Try deleting a file in English as well as other languages
  3. Make sure it works fine as intended

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: data_release PR or issue related to data_release module labels Jul 23, 2026
@fias06 fias06 added Priority: High PR or issue should be prioritised over others for review and testing 29.0.0 - Bugs Issues found during the release testing for 29.0.0 labels Jul 23, 2026
@fias06

fias06 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I was facing some issues while testing this PR, my VM was a bit slow/buggy so there is a chance there might be some minor bugs please let me know if any changes are required

@lapadulamichael

lapadulamichael commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@fias06 Reminder to fix format for unchanged lines as we discussed

@fias06
fias06 force-pushed the 2026_07_21_fixing_delete_file_issue_when_not_English branch from 1367ae2 to f8febee Compare July 25, 2026 17:22
@fias06
fias06 requested a review from lapadulamichael July 25, 2026 19:13
lapadulamichael
lapadulamichael reviewed Jul 27, 2026
View reviewed changes
Comment thread modules/data_release/jsx/dataReleaseIndex.js
lapadulamichael
lapadulamichael suggested changes Jul 27, 2026
View reviewed changes

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, just needs a rebase and I will re-test.

@lapadulamichael lapadulamichael added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jul 27, 2026
@fias06
fias06 force-pushed the 2026_07_21_fixing_delete_file_issue_when_not_English branch from 38f0f34 to 53f5daf Compare September 2, 2026 14:30
@github-actions github-actions Bot added Language: SQL PR or issue that update SQL code Language: PHP PR or issue that update PHP code Module: candidate_parameters PR or issue related to candidate_parameters module Module: document_repository PR or issue related to documen_repository module Module: redcap PR or issue related to redcap module labels Sep 2, 2026
@fias06
fias06 force-pushed the 2026_07_21_fixing_delete_file_issue_when_not_English branch from 53f5daf to 206028d Compare September 2, 2026 20:14
@github-actions github-actions Bot added Module: statistics PR or issue related to statistics module Module: issue_tracker PR or issue related to issue tracker module Module: dqt PR or issue related to (old) dqt module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: brainbrowser PR or issue related to brainbrowser module Module: candidate_list PR or issue related to candidate_list module Module: candidate_profile PR or issue related to candidate_profile module labels Sep 2, 2026
@github-actions github-actions Bot added Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: electrophysiology_uploader PR or issue related to electrophysiology_uploader Module: examiner PR or issue related to examiner module Module: help_editor PR or issue related to help_editor module Module: imaging_browser PR or issue related to imaging_browser module Module: imaging_uploader PR or issue related to imaging_uploader module Module: instrument_builder PR or issue related to instrument_builder module Module: instrument_list PR or issue related to instrument_list module Module: instrument_manager PR or issue related to instrument_manager module Module: media PR or issue related to media module Module: module_manager PR or issue related to module_manager module Module: mri_violations PR or issue related to mri_violations module Module: new_profile PR or issue related to new_profile module Module: next_stage PR or issue related to next_stage module Module: publication PR or issue related to the publication module Module: schedule_module PR or issue related to the schedule_manager module Module: server_processes_manager PR or issue related to the server_processes_manger Module: survey_accounts PR or issue related to the survey_accounts module Module: timepoint_list PR or issue related to the timepoint_list module Module: user_accounts PR or issue related to the user_accounts module Module: dicom_archive PR or issue related to dicom_archive module Multilingual Any tasks related to making LORIS multilingual labels Sep 2, 2026
@fias06
fias06 force-pushed the 2026_07_21_fixing_delete_file_issue_when_not_English branch from 206028d to b0800ea Compare September 2, 2026 20:16
@fias06
fias06 force-pushed the 2026_07_21_fixing_delete_file_issue_when_not_English branch from b0800ea to 097ecc5 Compare September 2, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lapadulamichael lapadulamichael Awaiting requested review from lapadulamichael

At least 1 approving review is required to merge this pull request.

Assignees

@fias06 fias06

@lapadulamichael lapadulamichael

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: brainbrowser PR or issue related to brainbrowser module Module: candidate_list PR or issue related to candidate_list module Module: candidate_parameters PR or issue related to candidate_parameters module Module: candidate_profile PR or issue related to candidate_profile module Module: configuration PR or issue related to configuration module Module: conflict_resolver PR or issue related to conflict_resolver module Module: create_timepoint PR or issue related to create_timepoint module Module: dashboard PR or issue related to dashboard module Module: data_release PR or issue related to data_release module Module: datadict PR or issue related to (old) datadict module Module: dicom_archive PR or issue related to dicom_archive module Module: dictionary PR or issue related to (new) dictionary module Module: document_repository PR or issue related to documen_repository module Module: dqt PR or issue related to (old) dqt module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: electrophysiology_uploader PR or issue related to electrophysiology_uploader Module: examiner PR or issue related to examiner module Module: help_editor PR or issue related to help_editor module Module: imaging_browser PR or issue related to imaging_browser module Module: imaging_uploader PR or issue related to imaging_uploader module Module: instrument_builder PR or issue related to instrument_builder module Module: instrument_list PR or issue related to instrument_list module Module: instrument_manager PR or issue related to instrument_manager module Module: issue_tracker PR or issue related to issue tracker module Module: media PR or issue related to media module Module: module_manager PR or issue related to module_manager module Module: mri_violations PR or issue related to mri_violations module Module: new_profile PR or issue related to new_profile module Module: next_stage PR or issue related to next_stage module Module: publication PR or issue related to the publication module Module: redcap PR or issue related to redcap module Module: schedule_module PR or issue related to the schedule_manager module Module: server_processes_manager PR or issue related to the server_processes_manger Module: statistics PR or issue related to statistics module Module: survey_accounts PR or issue related to the survey_accounts module Module: timepoint_list PR or issue related to the timepoint_list module Module: user_accounts PR or issue related to the user_accounts module Multilingual Any tasks related to making LORIS multilingual Priority: High PR or issue should be prioritised over others for review and testing State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fias06 @lapadulamichael