Skip to content

Clean up tarchive - #1501

Open
MaximeBICMTL wants to merge 1 commit into
aces:mainfrom
MaximeBICMTL:clean-up-tarchive
Open

Clean up tarchive#1501
MaximeBICMTL wants to merge 1 commit into
aces:mainfrom
MaximeBICMTL:clean-up-tarchive

Conversation

@MaximeBICMTL

@MaximeBICMTL MaximeBICMTL commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

Update the Python and Perl DICOM importers to accomodate for aces/Loris#11184 (which CI depends on, hence the failing tests).

Closes:

Testing

The Python code has corresponding integration tests.

The Perl code update was fully AI-generated (I am not touching that), but it has been reviewed and properly tested:

(loris) lorisadmin@loris:/data/loris/incoming$ dicomTar.pl ROM168_400168_V2 /data/loris/tarchive/2016 -database -profile test-profile  -verbose
WARNING: `dicomTar.pl` is deprecated and may eventually be removed. Please use the new `import-dicom-study` script instead, which also comes with new features like support for enhanced DICOMs, multi-echo series, and more.

Source: /tmp/dicomTar-test-zrF5Sz/source/ROM168_400168_V2
Target: /data/loris/tarchive/2016

Testing for database connectivity.
Database is available.

You will archive the dir		: ROM168_400168_V2

You are creating a tar with the following command:

tar -cf /data/loris/tarchive/2016/ROM168_400168_V2.tar ROM168_400168_V2


getting md5sums and gzipping!!

* Taken from dir                   :    /tmp/dicomTar-test-zrF5Sz/source/ROM168_400168_V2
* Archive target location          :    /data/loris/tarchive/2016/DCM_2016-08-19_ROM168_400168_V2.tar
* Name of creating host            :    127.0.1.1
* Name of host OS                  :    Linux
* Created by user                  :    lorisadmin
* Archived on                      :    2026-08-28 07:45:04
* dicomSummary version             :    1
* dicomTar version                 :    1
* md5sum for DICOM tarball         :    0ed355da34eeafa9dac46e6d54939a42  ROM168_400168_V2.tar
* md5sum for DICOM tarball gzipped :    be20de42eb718488513477a7434df01a  ROM168_400168_V2.tar.gz
* md5sum for complete archive      :    c0149ef11ef581e5cadf2b7c2a64d6e7  DCM_2016-08-19_ROM168_400168_V2.tar

Adding archive info into database

Removing temporary files from target location


Done adding archive info into database

@github-actions github-actions Bot added Language: Perl Issue or PR related to the Perl codebase Language: Python Issue or PR related to the Python codebase Package: DICOM importer PR or issue related to the DICOM importer labels Aug 28, 2026
@MaximeBICMTL
MaximeBICMTL force-pushed the clean-up-tarchive branch 2 times, most recently from 0e94855 to f679e61 Compare August 28, 2026 08:12
@MaximeBICMTL MaximeBICMTL added Cleanup Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test labels Aug 28, 2026
nullable and defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test Language: Perl Issue or PR related to the Perl codebase Language: Python Issue or PR related to the Python codebase Package: DICOM importer PR or issue related to the DICOM importer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant