DX-1128: localise Code + CodeSnippet (completes the visual lift)#3416
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f0aa029 to
712dec4
Compare
17d25cb to
2da466a
Compare
712dec4 to
2218333
Compare
2da466a to
6dff760
Compare
2218333 to
2f0072c
Compare
6dff760 to
c1b3585
Compare
2f0072c to
b67f0f1
Compare
c1b3585 to
0dd3b59
Compare
b67f0f1 to
f97a86b
Compare
0dd3b59 to
edfcd5c
Compare
58cbfa2 to
cf1a310
Compare
96e2ff3 to
a1cbcb6
Compare
cf1a310 to
a89f164
Compare
a89f164 to
988717a
Compare
a1cbcb6 to
f2b8c6b
Compare
f2b8c6b to
040b28a
Compare
988717a to
02983c0
Compare
040b28a to
7b0ecb0
Compare
02983c0 to
776d25f
Compare
|
Where these are used (review aid):
~ 𝒞𝓁𝒶𝓊𝒹𝑒 |
…+ drop @ably/ui Tailwind scan (DX-1128) Vendor Code and CodeSnippet (with ApiKeySelector, LanguageSelector, CopyButton, PlainCodeView, Tooltip) locally, off @ably/ui/core, completing the visual lift. Their internal Heroicon usages now import the components directly from @heroicons/react rather than routing names through the glyphs-only local Icon, and PlainCodeView's icon prop takes a ReactNode. Also prunes dead vendored CSS and drops the @ably/ui path from the Tailwind content scan.
776d25f to
5709946
Compare
kennethkalmer
left a comment
There was a problem hiding this comment.
And the last piece of the puzzle falls into place, nicely done
Part of DX-1128. Final PR — localises
Code+CodeSnippet(the last@ably/uivisual surface), then applies the end-state cleanup.What
Code,CodeSnippet(+ApiKeySelector,CopyButton,LanguageSelector,PlainCodeView,TooltipButton,languages) and the transitiveTooltipintosrc/components/ui/.MDXWrapperrewired; the SessionData seam stays (apiKeys passed as a prop). The subcomponents' internal Heroicon usages are imported directly from@heroicons/react(with the right outline/solid/micro variants), andPlainCodeView'siconprop takes aReactNode.node_modules/@ably/uiTailwind content glob, deletes the 5 dead vendored CSS files (legacy-buttons, dropdowns, layout, Slider, Flash), prunesshadows→ the 2 used tokens andforms→ the checkbox block. Compiledglobal.css8.4k → 6.7k lines.After this PR
docs' entire visual surface is local. Remaining
@ably/uiimports =insights(×6) +scripts(×2 — theSessionDataProvider/useSessionDatacontext API); the old SessionData Redux store +Flashreducer are gone after rebasing onto the 18.3.1main(Ken's #3418 migration) — parked infra, not design-system.Stack (DX-1128)
@ably/uitokens + reset/core CSS (merged)cn+heightsutilsIconcomponent (Ably glyphs only; Heroicons imported directly)@ably/uiTailwind scan#3410–#3416 are a linear stack, each building on the previous; #3409 has merged to
main. ▶ = this PR.Testing
🤖 Generated with Claude Code