fix(graphql): pin into-stream to v6 so the pkg build works on Node 20#7
Closed
mgrabina wants to merge 1 commit into
Closed
fix(graphql): pin into-stream to v6 so the pkg build works on Node 20#7mgrabina wants to merge 1 commit into
mgrabina wants to merge 1 commit into
Conversation
@yao-pkg/pkg require()s into-stream as CommonJS, but into-stream >=7 is ESM-only, so the pkg build fails with ERR_REQUIRE_ESM on Node 20+. core/build.rs runs this at compile time, which breaks `cargo build` for every rindexer consumer. Pin into-stream to v6 (last CommonJS release) via an npm override and regenerate the lockfile.
grothem
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
core/build.rsbuilds the embedded GraphQL server with@yao-pkg/pkgat compile time.pkgdoesrequire("into-stream")(CommonJS), butinto-stream>= 7 is ESM-only, so on Node 20+ the build fails:Because
build.rsruns this duringcargo build, it breaks the build for every rindexer consumer on a current Node — not just users of the embedded GraphQL server. The committedgraphql/package-lock.jsoneven resolvesinto-streamto9.x, sonpm cihits it too. Bumping@yao-pkg/pkgto latest does not help (it stillrequire()sinto-stream).Fix
Pin
into-streamto6(its last CommonJS release) via an npmoverridesingraphql/package.json, and regenerategraphql/package-lock.json.pkgcanrequire()a CommonJS module fine.Verified
npm run build(the exactpkginvocation frombuild.rs) now produces the binary instead of crashing withERR_REQUIRE_ESM.0.40end to end —cargo buildruns the graphql build successfully with no skip flag or workaround.The same issue exists upstream in
joshstevens19/rindexer; a matching override there keeps future fork syncs clean.