Repository navigation
Report the compiled imgui version in the main export table - #17
Merged
Merged
Conversation
d1ce764 switched EXPORT_ERROR to IMGUI_VERSION but left the real export table hardcoded at 18000, so every plugin reported Dear ImGui 1.80 no matter what it was built against. Harmless while the bindings were on 1.80; on anything newer arcdps sees a mismatch and silently drops all UI callbacks.
This was referenced Aug 16, 2026
Open
Owner
|
Good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d1ce764("Implement imgui version param") changedEXPORT_ERRORto reportIMGUI_VERSION, but the real export table a few lines above still reports a hardcoded18000, so that is what arcdps sees for every plugin regardless of what it was built against.This is invisible today, because
IMGUI_VERSIONis1_80_00— the two are equal. It stops being invisible the moment the bindings move off Dear ImGui 1.80: arcdps compares the reported number against its own and silently drops the plugin's UI callbacks on a mismatch, which since the 20260507 build (imgui 1.92.7) means every plugin loads but never draws.I hit this porting a plugin to 1.92.7: the plugin was correctly compiled against 1.92.7 but still announced 18000, and arcdps logged
The fix is to use the same constant the error struct already uses. No behaviour change on
main(both are 18000); it just stops the number being wrong onceIMGUI_VERSIONmoves.Separately I have the actual 1.92.7 bump working, but it depends on an imgui-rs fork, so I'll open that as its own PR rather than mixing it in here.