Skip to content

feat(request-events): move subtitle into title help tooltip - #710

Merged
Willxup merged 2 commits into
mainfrom
t3/request-events-title-tooltip
Nov 13, 2026
Merged

Willxup merged 2 commits into
mainfrom
t3/request-events-title-tooltip

Conversation

@Willxup

@Willxup Willxup commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Summary

Move the request event log description from the subtitle into the existing question-mark help tooltip. Keep the header ordered as title, help icon, then event count.

  • Preserve the original English, Simplified Chinese, and Traditional Chinese descriptions.
  • Remove the obsolete subtitle translation keys and references without changing shared Card subtitle support or credential request lists.
  • Cover title ordering, accessible help text, hover/focus/touch interactions, and existing tooltip regressions.

Validation

  • Frontend validation passed: 204 test files and 1,728 tests, lint, TypeScript checks, and production build.
  • Independent review reran affected tests (118 and 160 tests); all passed.
  • Browser acceptance passed against the real production frontend with mocked APIs: desktop Chromium in English/light and Chinese/dark, plus mobile WebKit emulation in English and Chinese. Checked header order, tooltip opening/dismissal, column settings, and export menu.
  • Browser checks did not use a live Go backend or physical iOS device.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T06:19:06.377761Z 6c064f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Willxup
Willxup merged commit dbd4d41 into main Nov 13, 2026
5 checks passed
@Willxup
Willxup deleted the t3/request-events-title-tooltip branch November 13, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant