Skip to content

fix(models): retain tab data across navigation - #698

Merged
Willxup merged 3 commits into
mainfrom
worktree/models-tab-state
Nov 9, 2026
Merged

Willxup merged 3 commits into
mainfrom
worktree/models-tab-state

Conversation

@Willxup

@Willxup Willxup commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Keep the loaded model catalog and pricing configuration when navigating away from Models and back, instead of showing the initial loading state again. Store the data in the page lifecycle while continuing to unmount the tab UI and dialogs.

Preserve first-load behavior, manual refresh, and updates after pricing edits. Invalidate pricing snapshots after a successful save, deletion, or sync so returning to Models retries if the follow-up read failed, while keeping the previous content visible. Add focused regressions without introducing polling or persistent caching.

Validation

  • npm --prefix web run test: 202 test files and 1720 tests passed.
  • npm --prefix web run lint, npm --prefix web run typecheck, and npm --prefix web run build: passed on the same source tree.
  • Save/delete/sync recovery regressions failed before the fix and passed afterward.
  • Chromium against the complete production frontend with mocked APIs: initial loading, tab navigation, manual refresh, and recovery after a successful save followed by a failed read passed without page errors.
  • Independent review of the Models state-retention change found no issues. Live-backend integration was not tested.

Keep the model catalog and pricing configuration in the page lifecycle so returning to Models reuses loaded content. Preserve first-load, manual refresh, and pricing mutation behavior while leaving tab UI and dialogs scoped to the active tab.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T10:48:38.392461Z e446257 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ed35ad952

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Merge main into the Models tab state fix while retaining both the request-event imports and the model data imports.
Retain the displayed prices but mark their snapshot stale after a successful save, deletion, or sync. If the follow-up read fails, returning to Models retries the current configuration instead of treating the old snapshot as loaded.
@Willxup

Willxup commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: e446257763

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Willxup
Willxup merged commit bf5fb1c into main Nov 9, 2026
5 checks passed
@Willxup
Willxup deleted the worktree/models-tab-state branch November 9, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant