Repository navigation
fix(models): retain tab data across navigation - #698
Conversation
Keep the model catalog and pricing configuration in the page lifecycle so returning to Models reuses loaded content. Preserve first-load, manual refresh, and pricing mutation behavior while leaving tab UI and dialogs scoped to the active tab.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ed35ad952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merge main into the Models tab state fix while retaining both the request-event imports and the model data imports.
Retain the displayed prices but mark their snapshot stale after a successful save, deletion, or sync. If the follow-up read fails, returning to Models retries the current configuration instead of treating the old snapshot as loaded.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Keep the loaded model catalog and pricing configuration when navigating away from Models and back, instead of showing the initial loading state again. Store the data in the page lifecycle while continuing to unmount the tab UI and dialogs.
Preserve first-load behavior, manual refresh, and updates after pricing edits. Invalidate pricing snapshots after a successful save, deletion, or sync so returning to Models retries if the follow-up read failed, while keeping the previous content visible. Add focused regressions without introducing polling or persistent caching.
Validation
npm --prefix web run test: 202 test files and 1720 tests passed.npm --prefix web run lint,npm --prefix web run typecheck, andnpm --prefix web run build: passed on the same source tree.