[StackIR] Optimize the simple case of a multivalue tee and extracts#8623
Merged
kripken merged 18 commits intoWebAssembly:mainfrom Apr 20, 2026
Merged
[StackIR] Optimize the simple case of a multivalue tee and extracts#8623kripken merged 18 commits intoWebAssembly:mainfrom
kripken merged 18 commits intoWebAssembly:mainfrom
Conversation
Closed
tlively
approved these changes
Apr 17, 2026
| ) | ||
| ) | ||
|
|
||
| ;; CHECK: (func $multivalue-return-too-short (type $3) (result i32 f64) |
Member
There was a problem hiding this comment.
Might be interesting to add round trip output, too, to make sure the binary writer still does the right thing.
Member
Author
There was a problem hiding this comment.
Already done 😉 see the command above
Member
There was a problem hiding this comment.
Oh, I see. It's too bad we can't get a text output that matches the written binary exactly (i.e. with the tuple pseudoinstructions lowered away).
Member
Author
There was a problem hiding this comment.
We can get close without the roundtrip - the StackIR is printed right before binary emitting. I pushed a change now to include both outputs (with a different lit prefix).
tlively
approved these changes
Apr 18, 2026
tlively
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting a multivalue from e.g. a call and then consuming it immediately,
we get this pattern:
We save the entire tuple to a local, then read index by index. In StackIR
we can just remove all the tuple operations, as the value is on the stack
and ready to be used.
Fixes #8618