Skip to content

docs: Add information about building jdk and output - #60

Merged
Monmcgt merged 5 commits into
Weave-MC:masterfrom
Kathund:docs/building/jdk
Aug 20, 2026
Merged

Monmcgt merged 5 commits into
Weave-MC:masterfrom
Kathund:docs/building/jdk

Conversation

@Kathund

@Kathund Kathund commented May 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Kathund Kathund changed the title docs: Add information about JDK requirements for building docs: Add information about building jdk and output May 3, 2026
Comment thread README.md Outdated
cd Weave-Loader
```

Building requires Java 17 JDK to work. If you currently don't have this please download it from [here](https://adoptium.net/temurin/releases?version=17&os=any&arch=any) (or use your own download source)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure if this is necessary since we've already had org.gradle.toolchains.foojay-resolver-convention plugin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean maybe. I have never looked into that plugin much nore used it personally. My default jdk was 8 and it complained when building because old version so adding docs like this seams nicer for end users trying to use something. A lot of projects that explain how to build from source do include a list of the "requirements"/tooling they use for building so I feel adding it either way still helps

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye I think it should be fine to keep this

@Monmcgt
Monmcgt requested a review from 770grappenmaker May 3, 2026 08:54

@770grappenmaker 770grappenmaker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engrish

Comment thread README.md Outdated
Comment thread README.md Outdated
Co-authored-by: Koen Oostveen <770grappenmaker@gmail.com>
@Kathund

Kathund commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

Engrish

It's okay! I did NOT proof read my commits 🙏

@770grappenmaker

Copy link
Copy Markdown
Contributor

I'm just joking a little, not making fun of you 😅

@Kathund
Kathund requested a review from Monmcgt May 6, 2026 09:09
@770grappenmaker

Copy link
Copy Markdown
Contributor

Made a typo, "ready use use" should be "ready to use"

@Monmcgt
Monmcgt merged commit 4462781 into Weave-MC:master Aug 20, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants