Escape output in adminhtml import info templates#87
Open
pbritka wants to merge 1 commit into
Open
Conversation
The import_info.phtml and info_type_files.phtml templates echoed values without escaping, which the Magento2 coding standard flags and is an XSS risk for any attacker-influenced import metadata. Wrap dynamic output in the block's $escaper (escapeHtml / escapeHtmlAttr / escapeUrl). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import_info.phtmlandinfo_type_files.phtmlecho values without escaping — flagged by the Magento2 coding standard and an XSS risk for attacker-influenced import metadata. Dynamic output is wrapped in the block$escaper(escapeHtml/escapeHtmlAttr/escapeUrl).Note: may overlap with the open #78 "PHP Codesniffer pass" — happy to rebase/coordinate.