Guard CLI progress TTY detection when POSIX ext is unavailable#86
Open
pbritka wants to merge 1 commit into
Open
Guard CLI progress TTY detection when POSIX ext is unavailable#86pbritka wants to merge 1 commit into
pbritka wants to merge 1 commit into
Conversation
Progress\Factory::get() calls posix_isatty(STDOUT) directly. On PHP builds without the posix extension (e.g. some production CLI environments), this is an undefined function and fatals with "Call to undefined function" when not in developer mode. Wrap the check in function_exists() so it falls back to NullProgress, which is the correct behaviour for a non-TTY context. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progress\Factory::get()callsposix_isatty(STDOUT)directly. On PHP builds without the posix extension (some production CLI environments), this is an undefined function and fatals with Call to undefined function whenever the app is not in developer mode — breaking import crons.The TTY check is wrapped in
function_exists('posix_isatty')via a smallisInteractiveCliOutput()helper. Without posix it falls back toNullProgress, the correct behaviour for a non-TTY/cron context. No change where posix is present.