PHP 8.4/8.5, Symfony 7 & Magento 2.4.9 compatibility#85
Open
pbritka wants to merge 1 commit into
Open
Conversation
- Add explicit nullable type declarations (?Type) to fix the PHP 8.4 implicit-nullable deprecation across Command, Archiver, Exception, Import, Report, Transformer and Ui classes. - Add Symfony Console int return types (execute(): int) for Symfony 7. - Drop the no-op ReflectionProperty::setAccessible() call (a no-op since PHP 8.1, deprecated in 8.5) in ProductWriter. - composer.json: allow symfony/console ^7.0; loosen the php constraint; and replace the abandoned tightenco/collect with illuminate/collections (namespace-transparent: both provide Illuminate\Support\Collection). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility fixes for PHP 8.4/8.5, Symfony 7 and Magento 2.4.9.
?Type) for params with anulldefault, fixing the implicit-nullable deprecation acrossCommand,Archiver,Exception,Import,Report,Transformer,Ui.execute(): intreturn types on console commands; allowsymfony/console ^7.0.ReflectionProperty::setAccessible()call inProductWriter(no-op since 8.1, deprecated in 8.5).tightenco/collectis abandoned and caps PHP support; swapped toilluminate/collections. Namespace-transparent (both provideIlluminate\Support\Collection), so no code changes. Open to a different replacement if you prefer.Tested on Magento 2.4.7–2.4.9 (PHP 8.1–8.5).