Skip to content

MemberCount: fix online count when the member list is hidden - #4727

Merged
Nuckyz merged 2 commits into
Vendicated:devfrom
iFlex0x:memberCount-preload
Oct 22, 2026
Merged

Nuckyz merged 2 commits into
Vendicated:devfrom
iFlex0x:memberCount-preload

Conversation

@iFlex0x

@iFlex0x iFlex0x commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Describe your Changes

hide member list leaves the tooltip online count at "?" because the preload check only subscribes for MEMBERS allowed NONE too so the count loads without opening the list.
tested with hide member list on.

Checklist before submitting

  • I have read the contribution rules and made sure this pull request complies with it
  • This pull request was written by me, and not an AI agent.
  • I understand that if any of the above conditions are not met, this pull request will be closed and I will be banned from future contributions without further warning

@Nuckyz Nuckyz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure it still works

Comment thread src/plugins/memberCount/index.tsx Outdated
Comment thread src/plugins/memberCount/index.tsx Outdated
@iFlex0x

iFlex0x commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Make sure it still works

thanks, applied both and retested with the member list hidden. works.

@iFlex0x
iFlex0x requested a review from Nuckyz October 22, 2026 13:55
@Nuckyz
Nuckyz changed the base branch from main to dev October 22, 2026 14:15
@Nuckyz
Nuckyz merged commit fa5b5b0 into Vendicated:dev Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants