feat: fix close floating elements and modals when esc keydown#9670
Open
EldarMuhamethanov wants to merge 7 commits into
Open
feat: fix close floating elements and modals when esc keydown#9670EldarMuhamethanov wants to merge 7 commits into
EldarMuhamethanov wants to merge 7 commits into
Conversation
EldarMuhamethanov
added
cmp:modal-card
cmp:date-input
cmp:date-range-input
cmp:popover
EldarMuhamethanov
force-pushed
the
e.muhamethanov/fix-close-overlay-by-escr
branch
from
fa405b7 to
3aff587
Compare
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9670/954eabffaf317232ee336b328ad06a1ad5f47fd4/pkg/@vkontakte/vkui/_pkg.tgzCommit 954eabf |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9670 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 442 442
Lines 12236 12244 +8
Branches 4442 4443 +1
=======================================
+ Hits 11655 11663 +8
Misses 581 581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vkcom-publisher
added
the
pr-needs-work
vkcom-publisher
removed
the
pr-needs-work
vkcom-publisher
added
pr-needs-work
# Conflicts: # packages/vkui/src/components/CalendarTime/CalendarTime.tsx # packages/vkui/src/components/DateInput/DateInput.test.tsx # packages/vkui/src/hooks/useGlobalEscKeyDown.ts
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
vkcom-publisher
removed
the
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Раньше несколько слоёв (модальные окна, выпадающие списки, поповеры и т.п.) могли одновременно подписываться на закрытие по Escape, из-за чего одно нажатие закрывало сразу несколько уровней UI. В этой доработке вводится единый диспетчер на уровне документа: все активные обработчики Escape регистрируются в общий стек, и на одно нажатие обрабатывается только верхний (последний зарегистрированный) слой.
Закрытие модальных карточек/страниц по Escape переведено на тот же механизм, что и у остальных компонентов, чтобы поведение было согласованным. Для селектов и связанных контролов закрытие по Escape вынесено в глобальный слой (чтобы оно участвовало в общем порядке «снаружи внутрь»), убраны точечные
stopPropagation/localобходы, которые маскировали проблему.В общем теперь логика закрытия такая: кто последний открылся, то первый закроется при нажатии
ESCRelease notes
Исправления