Refactor backend booking emails to use shared date utils#972
Closed
taroj1205 wants to merge 1 commit into
Closed
Conversation
Contributor
Preview Deployment Status✅ Storybook Preview: https://629f207a.uabc-storybook.pages.dev ✅ Frontend Preview: https://50b50be4.uabc.pages.dev |
e50e0d4 to
42c1e49
Compare
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
42c1e49 to
0702db4
Compare
Expose shared date helpers for weekday, day-month, and 24-hour time formatting. This lets backend code use the configured Day.js wrapper instead of ad hoc date formatting. refactor(backend): use shared date utils in mail service Replace inline booking email date formatting with shared helpers. This keeps MailService on the configured Day.js utility path. test(backend): verify booking email payload via route Exercise the real booking confirmation email flow through /api/bookings. This keeps the integration coverage on the rendered email payload.
0702db4 to
7aea98b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dayjs.tswrapperType of change
How Has This Been Tested?
Checklist before requesting a review