Skip to content

Vps 85/improve font list#416

Open
GogaIV wants to merge 4 commits into
masterfrom
VPS-85/improve-font-list
Open

Vps 85/improve font list#416
GogaIV wants to merge 4 commits into
masterfrom
VPS-85/improve-font-list

Conversation

@GogaIV

@GogaIV GogaIV commented May 26, 2026

Copy link
Copy Markdown
Contributor

Issue

Couldn't see fonts till searching

Solution

used the same idea as the modal popup for state operations (createPortal), has scrollbar for overflow and max height

Images

image image image

Risk

could possibly overlay important items, but my testing didn't show any also its a very small component

Checklist

  • Acceptance criteria met
  • Wiki documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous integration build passing

@linear

linear Bot commented May 26, 2026

Copy link
Copy Markdown

VPS-85

@GogaIV GogaIV requested review from harbassan and hazikchaudhry May 26, 2026 13:30

@leowla leowla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The dropdown should close if user clicks anywhere else in the toolbar.
  • The dropdown position should always stick to the input box, or close if input box moves.
CleanShot.2026-06-01.at.14.29.00.mp4

Other minor stuff:

  • No keyboard controls like Escape to close, Enter to select, and Tab or arrow keys to go up/down the list
  • Safari is suggesting to input my contacts names probably because the placeholder has "Name" in it.

@harbassan harbassan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to leos point, investigate the native popover api, which should add auto handling of ESC, clickout etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants