Repository navigation
Fix Android build: missing System.IO and Gradle namespace conflict - #586
Merged
achimmihca merged 2 commits intoOct 21, 2026
Merged
Conversation
The Android-only code that creates the internal song folder used Directory without importing System.IO, which fails to compile when building for Android (CS0103). This restores the fix from cb7e755 that was lost during the Melody Mania reintegration (1b39a5d). Co-Authored-By: Claude Code <noreply@anthropic.com>
… conflict ingamedebugconsole and androidruntimepermissions both use the com.yasirkula.unity Android namespace. Gradle 9 / AGP 9 rejects this with "Namespace ... is used in multiple modules and/or libraries", which breaks the Android build. Upgrade to the versions already used by the companion app (1b4cbcb): - androidruntimepermissions v1.3.1 - ingamedebugconsole v1.9.0 Adapt LoadingSceneControl to the new permission API: CheckPermission now returns bool and RequestPermission was replaced by RequestPermissionAsync. Co-Authored-By: Claude Code <noreply@anthropic.com>
Collaborator
|
Hi, your findings are correct. Thank you! |
achimmihca
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I'm compiling UltraStar Play 1.7.1 for Android so I can play it on my S24, which
I've dedicated as a gaming station, and take advantage of the improvements in
this version.
Full disclosure: the rest of this text was generated by AI, but I actually tested
the changes myself and they work perfectly, so I endorse them.
1. DefaultSettingsFactory: missing System.IO
The Android-only code that creates the internal song folder uses Directory.Exists
and Directory.CreateDirectory without importing System.IO, so the Android build
fails with CS0103. This was already fixed in cb7e755, but the fix was lost in
the Melody Mania reintegration (1b39a5d), so this restores it.
2. AndroidManifest namespace conflict in the yasirkula plugins
ingamedebugconsole and androidruntimepermissions both use the com.yasirkula.unity
Android namespace. Gradle 9 / AGP 9 rejects this with:
which breaks the Android build. I upgraded them to the versions already used by
the companion app in 1b4cbcb:
The permission API changed in that version, so LoadingSceneControl now uses
CheckPermission (bool) and RequestPermissionAsync.
Third issue (separate PR)
In IL2CPP player builds the app crashes on startup because the visualelementevents
package still generates a HierarchyEvent callback with the old two-parameter
signature, while Unity 6.5 now passes an additionalContext argument. I opened a PR
in the package repo: achimmihca/Unity-VisualElementEvents#1.
The build succeeds with the changes in this PR. Once the package PR is merged I'll
bump the dependency in the manifest so the app also starts correctly.
Thanks!