Add per-marker size configuration for STag pose estimation#285
Open
RokPre wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using different physical sizes for different STag IDs.
Previously, stag_detect assumed a single global marker_size for all detected markers. That worked only
when every marker in the environment had the same printed size. With this change, the node can
optionally load a YAML config file that maps marker IDs to sizes, and use the configured size for pose
estimation on a per-marker basis.
This allows mixed deployments such as:
Implementation summary:
pose estimation
Example config:
default_marker_size: 0.175
markers:
- id: 0
size: 0.175
- id: 5
size: 0.09
- id: 6
size: 0.09
Example launch usage:
ros2 launch stag_detect stag_detect.launch.py config_file:=/path/to/marker_sizes.yaml