Skip to content

Fix broken healpix notebook #1511

Merged
rajeeja merged 1 commit into
mainfrom
rajeeja/fix_healpix_notebook
May 18, 2026
Merged

Fix broken healpix notebook #1511
rajeeja merged 1 commit into
mainfrom
rajeeja/fix_healpix_notebook

Conversation

@rajeeja
Copy link
Copy Markdown
Contributor

@rajeeja rajeeja commented May 18, 2026

Empty circles were showing up as the docs build was rendering that HoloViews/GeoViews plot with the default Bokeh backend, which can show only the Orthographic outline/empty circles in the static docs context. I changed the Healpix plotting cell to explicitly use backend="matplotlib"

…s the implicit backend for a static projected GeoViews plot.
@rajeeja rajeeja requested review from erogluorhan and rljacob May 18, 2026 19:48
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Copy Markdown
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Do we know the reason for bokeh backend not working as before?

@rajeeja
Copy link
Copy Markdown
Contributor Author

rajeeja commented May 18, 2026

Thanks for looking into this! Do we know the reason for bokeh backend not working as before?

Some package upgraded the PyViz stack or RTD caused the failure..I was trying to pin it down, but couldn't.

@erogluorhan
Copy link
Copy Markdown
Member

I think we need to figure that out before moving forward with this PR as is.

@rajeeja
Copy link
Copy Markdown
Contributor Author

rajeeja commented May 18, 2026

I think we need to figure that out before moving forward with this PR as is.

Ok, but I think we can keep this fix as matplotlib is good for static plot; Bokeh is fundamentally an interactive, browser-based, and JavaScript-heavy plotting library.

@erogluorhan
Copy link
Copy Markdown
Member

I think we need to figure that out before moving forward with this PR as is.

Ok, but I think we can keep this fix as matplotlib is good for static plot; Bokeh is fundamentally an interactive, browser-based, and JavaScript-heavy plotting library.

I agree. Just wanted to point that having this PR fixed shouldn't lead us to forget the issue, whcih would still show up in user's workflows. Maybe open an issue for that if you're not planning to tackle that and then merge this?

@rajeeja rajeeja merged commit 735a1dd into main May 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants