Fix Flux1 data types - #147
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Flux1 data type classes to remove inheritance hierarchies and use direct implementations instead. The changes eliminate dependencies on parent classes (BasicCrossIndustryInvoice, EN16931, and Minimum implementations) in favor of standalone class implementations with promoted constructor properties.
Key Changes:
- Removes parent class inheritance from Flux1 classes in favor of direct implementation
- Replaces parent constructor calls and getter overrides with promoted properties
- Updates namespace imports to use Flux1-specific data types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Flux1/CrossIndustryInvoice.php | Removed BasicCrossIndustryInvoice inheritance; implements interface directly with promoted properties and simplified getters |
| src/DataType/Flux1/SupplyChainTradeTransaction.php | Removed Minimum\SupplyChainTradeTransaction inheritance; standalone implementation with promoted properties |
| src/DataType/Flux1/ApplicableHeaderTradeDelivery.php | Removed unused ShipToTradeParty import |
| src/DataType/Flux1/ApplicableHeaderTradeAgreement.php | Removed Minimum\ApplicableHeaderTradeAgreement inheritance; standalone implementation with promoted properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samueld-pdp
force-pushed
the
fix/add-flux1-profile
branch
from
October 27, 2025 08:52
f317a1a to
9703c7c
Compare
samueld-pdp
force-pushed
the
fix/add-flux1-profile
branch
from
October 27, 2025 08:58
9703c7c to
5909955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.