Skip to content

Bug Fix: Remove sendCommand(NORMALDISPLAY) from setContrast() #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelstoer merged 3 commits into from
Jan 9, 2026
Merged

Bug Fix: Remove sendCommand(NORMALDISPLAY) from setContrast() #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
787feb2
Add pram to setContrast and setBrightness methods to preserve display…
jasonacox Dec 31, 2025
07c2bb7
Remove trailing space
jasonacox Dec 31, 2025
cf64572
Refactor setContrast and setBrightness methods to remove forceNormal …
jasonacox Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ void normalDisplay(void);
// normal brightness & contrast: contrast = 100
void setContrast(uint8_t contrast, uint8_t precharge = 241, uint8_t comdetect = 64);

// Convenience method to access
// Convenience method to access setContrast with only brightness parameter
void setBrightness(uint8_t);

// Turn the display upside down
Expand Down
1 change: 0 additions & 1 deletion src/OLEDDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,6 @@ void OLEDDisplay::setContrast(uint8_t contrast, uint8_t precharge, uint8_t comde
sendCommand(SETVCOMDETECT); //0xDB, (additionally needed to lower the contrast)
sendCommand(comdetect); //0x40 default, to lower the contrast, put 0
sendCommand(DISPLAYALLON_RESUME);
sendCommand(NORMALDISPLAY);
sendCommand(DISPLAYON);
}

Expand Down
2 changes: 1 addition & 1 deletion src/OLEDDisplay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ class OLEDDisplay : public Stream {
// normal brightness & contrast: contrast = 100
void setContrast(uint8_t contrast, uint8_t precharge = 241, uint8_t comdetect = 64);

// Convenience method to access
// Convenience method to access setContrast with only brightness parameter
void setBrightness(uint8_t);

// Reset display rotation or mirroring
Expand Down
Loading