Migrate to ReScript 12; compatibility with ReScript 13 alpha#36
Conversation
|
Thank you! I am often unsure how many people still use my libraries and whether they need migrating. I'll look at this soon. |
| { | ||
| "module": "commonjs", | ||
| "in-source": false | ||
| "in-source": true |
There was a problem hiding this comment.
Since the JS files aren't distributed on NPM anymore, which to be honest I should've changed years ago, what's the harm in leaving this as false? It would make the JS diffs in this PR easier to review (assuming git is smart enough to treat them as renamed at that point).
There was a problem hiding this comment.
I would consider in-source best practice in general, and it allows us to just add the whole lib dir to .gitignore.
The file extension also changed from .bs.js to .res.js. So there is a move in any case.
But GitHub also shows changes in the moved files, except in some cases where there were too many.
Summary
Migrate
rescript-nodejsto ReScript 12 and make the codebase compatible with the ReScript 13 alpha.This updates the project to ReScript 12 package conventions, moves compiled JS output in-source, and rewrites affected bindings/tests to match the newer standard library and syntax changes.
What Changed
rescript.json.res.jsfiles in-source instead of generating.bs.jsfiles underlib/jsnullable,Null,dict,promise,Symbol,JSON, andtypeofBreaking Changes
()callsrc/plus package metadata; generated.res.js, tests, examples, and docs are no longer publishedNotes
.ressources insrc/,test/, andexamples/, replacing the oldlib/jsoutput layoutREADME.mdinstallation instructions now referencerescript.jsonanddependencies