ci: issue templates, PR template, working tier-2 GLSL validation#2
Merged
Conversation
Issue templates (YAML, replaces old .md): - bug-report: type dropdown, version fields, log + screenshot sections - symptom-request: clinical source required for new VSS effects - clinical-feedback: dedicated template for patients/clinicians - iris-compat: version-specific compatibility reports PR template: updated for conventional commits, removed manual CHANGELOG requirement Tier-2 test rewrite: - Previous setup downloaded Fabric installer but never ran it, so MC client files did not exist — the launch command was a dead placeholder - New approach: lightweight Docker image (glslangValidator + Python), injects an Iris uniform shim into each .vsh/.fsh and validates with glslangValidator — no Minecraft needed, runs in ~60s - iris-compat.yml simplified: Tier 1 lint + Tier 2 GLSL validation, replaces the 7-job MC version matrix that could never actually run
…nifest to 0.1.0 - iris-shim.glsl: removed texcoord declarations (shaders declare their own varyings; shim was causing redefinition errors in both vert and frag stages) - entrypoint.sh: replaced glslangValidator -I approach with a Python inline preprocessor — glslangValidator treats '/lib/foo' as an absolute system path, not relative to -I, so includes must be resolved before validation - .release-please-manifest.json: initial version set to 0.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Issue templates (4 new YAML templates, old
.mdremoved)Labels (8 new)
Created directly on the repo:
iris-compat,visual-glitch,symptom-request,clinical,translation,performance,player-report,needs-reproPR template
Updated for conventional commits; manual CHANGELOG entry checkbox replaced by commit convention note.
Tier-2 testing — complete rewrite
The previous setup was broken: the Fabric installer jar was downloaded but never executed, so no Minecraft client files existed and the launch command was a dead placeholder that would always fail silently.
New approach:
glslangValidator+ Python, nothing elseiris-shim.glslinjects all Iris uniforms/varyings so glslangValidator can resolve every symbolentrypoint.shvalidates each.vsh/.fshfile individually — passes the stage flag correctly, strips the#versionline, prepends the shimiris-compat.ymlsimplified: Tier 1 lint → Tier 2 GLSL validation (replaces the 7-job MC version matrix)