Skip to content

fix(wujie-core): skip rendering when template is empty to avoid flashing "undefined" text #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fadeaway1680 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

fix(wujie-core): skip rendering when template is empty to avoid flashing "undefined" text #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/wujie-core/src/shadow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,12 @@ export async function renderTemplateToShadowRoot(
iframeWindow: Window,
template: string
): Promise<void> {
// 并发 startApp（如 React StrictMode 双挂载）竞态下 template 可能为空。
// 若继续渲染，DOMParser.parseFromString(undefined) 与 html.innerHTML = undefined
// 都会把字面量 "undefined" 渲染进 shadowRoot，表现为首次加载闪现 undefined 文本。
// 这里直接跳过，等真实模板 active 时会重新渲染。
if (!template) return;

const html = renderTemplateToHtml(iframeWindow, template);
// 处理 css-before-loader 和 css-after-loader
const processedHtml = await processCssLoaderForTemplate(iframeWindow.__WUJIE, html);
Expand Down Expand Up @@ -295,6 +301,9 @@ export async function renderTemplateToIframe(
iframeWindow: Window,
template: string
): Promise<void> {
// 同 renderTemplateToShadowRoot：空 template 直接跳过，避免降级渲染把 "undefined" 写入 iframe document
if (!template) return;

// 插入template
const html = renderTemplateToHtml(iframeWindow, template);
// 处理 css-before-loader 和 css-after-loader
Expand Down