fix(Log): restore inherited event properties - #737
Open
dvd233 wants to merge 1 commit into
Open
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Svelte log-tree rewrite replaced the previous
for...intraversal withObject.keys(). As a result,TouchEventexpansion only exposed its ownisTrustedproperty and omitted inherited fields such astouches,targetTouches, andchangedTouches.On the current Svelte 5 build, rendering those inherited host objects through legacy reactive blocks can also trigger
Illegal invocationwhile Svelte deep-reads native properties. The tree/value updates now run throughbeforeUpdate, which preserves updates without recursively inspecting host objects.Verification
npx tsc --build tsconfig.type.jsonnpm run build:wxnpm run buildnpm pack --dry-run --jsonTouch Eventdev case and expandedtype,touches,targetTouches, andchangedToucheswith no page errorsFixes #609