[PATCH] arm: dts: mediatek: mt6589: Fix timer interrupt trigger type#55
Draft
akku1139 wants to merge 1 commit into
Draft
[PATCH] arm: dts: mediatek: mt6589: Fix timer interrupt trigger type#55akku1139 wants to merge 1 commit into
akku1139 wants to merge 1 commit into
Conversation
MT6589 uses IRQ_TYPE_LEVEL_LOW for arch timer, but I sent a patch using IRQ_TYPE_LEVEL_HIGH. The timer worked correctly regardless of whether IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_LEVEL_HIGH was used in the Device Tree, therefore, there is no actual impact. However, this is not a correct description of the hardware so correct it. Fixes: 2a5d545 ("arm: dts: mediatek: mt6589: Add Arm Generic Timer node") Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MT6589 uses IRQ_TYPE_LEVEL_LOW for arch timer, but I sent a patch using IRQ_TYPE_LEVEL_HIGH.
The timer worked correctly regardless of whether IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_LEVEL_HIGH was used in the Device Tree, therefore, there is no actual impact. However, this is not a correct description of the hardware so correct it.
Fixes: 2a5d545 ("arm: dts: mediatek: mt6589: Add Arm Generic Timer node")